It is a solid attempt, but I woudl recommend taking some time to study reference pictures of crystals (or some physical crystals). It looks a bit more like you've tried to work it from your imagination than that you're working from experience (you can trust me, I'm a geologist) Still it is an admirable effort, I just think you could improve it with some more reference.
Thank you. Glad you like the crystals.